IMO putting the logic completely into hydra will be too limiting. If hydra just gives a nix expression some info about the PRs, then the nix expression can do arbitrary things (e.g. only build PRs from trusted users, or that don't change stdenv, or whatever). If it's a jobset tab then you have to add every possible variation into the hydra UI.
----- Original Message ----- From: "Domen Kožar" <do...@dev.si> To: "Shea Levy" <s...@shealevy.com> Cc: "Graham Christensen" <gra...@grahamc.com>, "Ericson John" <john_eric...@brown.edu>, "nix-dev" <nix-dev@lists.science.uu.nl> Sent: Thu, 28 Apr 2016 11:32:53 +0100 Subject: Re: [Nix-dev] Continuous Integration I was talking to Aszlig about this and it would be best if PRs would be a tab on the jobset. Since jobset defines the inputs, it would be tested for PRs against that specific branch. On Thu, Apr 28, 2016 at 11:30 AM, <s...@shealevy.com [1]> wrote: It can set pull request statuses (e.g. see https://github.com/shlevy/hydra-github-status-test/pull/3 [2]), but currently you have to manually create the jobset corresponding to the PR and ensure that the relevant jobs are captured by the status plugin. If https://github.com/NixOS/hydra/pull/277 [3] is merged, then there is one step left to get automatic PR management: An input plugin which fetches information about open PRs on a repo. I'll write it if 277 ever gets in, but without 277 or something like it there's no point. ----- Original Message ----- From: "Graham Christensen" <gra...@grahamc.com [4]> To: "Domen Kožar" <do...@dev.si [5]> Cc: "Ericson John" <john_eric...@brown.edu [6]>, "nix-dev" <nix-dev@lists.science.uu.nl [7]> Sent: Wed, 27 Apr 2016 18:23:55 -0500 Subject: Re: [Nix-dev] Continuous Integration Domen Kožar <do...@dev.si [8]> writes: > It doesn't build PRs, just updates the status. > Does this mean it can build specific branches (master, release-16.04..) and set the commit status on those commits? ie: doesn't have anything to do with pull request statuses? Best, Graham _______________________________________________ nix-dev mailing list nix-dev@lists.science.uu.nl [9] http://lists.science.uu.nl/mailman/listinfo/nix-dev [10] Links: ------ [1] mailto:s...@shealevy.com [2] https://github.com/shlevy/hydra-github-status-test/pull/3 [3] https://github.com/NixOS/hydra/pull/277 [4] mailto:gra...@grahamc.com [5] mailto:do...@dev.si [6] mailto:john_eric...@brown.edu [7] mailto:nix-dev@lists.science.uu.nl [8] mailto:do...@dev.si [9] mailto:nix-dev@lists.science.uu.nl [10] http://lists.science.uu.nl/mailman/listinfo/nix-dev
_______________________________________________ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
