Hi Frank,

Thanks for the update! However, I got the following error when I tried your
change:

  error: undefined variable ‘freetype’ at /home/james/big/work/nixpkgs_
wd/aux/pkgs/games/naev/default.nix:22:75

Did you try out your new expression before attaching it? We're happy to
apply your change, but only once we're sure it's been properly tested!

Also, it would be helpful if you would either (a) create a pull request on
GitHub, or (b) attach your change in patch format, e.g. using git
format-patch. (Jookia, I believe it's our tradition to accept mailing list
patches, since some people don't like GitHub, perhaps because it is not an
open-source tool.)

James

On 10 May 2017 at 13:48, Jookia <166...@gmail.com> wrote:

> On Wed, May 10, 2017 at 08:30:13PM +0200, Frank Wijnans wrote:
> > Hi,
> >
> > My first attempt on packaging.
> > Updated to new version, added some dependencies.
> >
> > Greetings,
> >       Frank
>
> Might want to throw in freetype as well since it's needed for building on
> ARM.
> And to make this a github pull request or patch someone can apply.
> _______________________________________________
> nix-dev mailing list
> nix-dev@lists.science.uu.nl
> https://mailman.science.uu.nl/mailman/listinfo/nix-dev
>
_______________________________________________
nix-dev mailing list
nix-dev@lists.science.uu.nl
https://mailman.science.uu.nl/mailman/listinfo/nix-dev

Reply via email to