Branch: refs/heads/master
  Home:   https://github.com/NixOS/nix
  Commit: 00aa7c6705c073aab8b24ae945ea9a09d5d256aa
      
https://github.com/NixOS/nix/commit/00aa7c6705c073aab8b24ae945ea9a09d5d256aa
  Author: Eelco Dolstra <edols...@gmail.com>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M src/libstore/s3-binary-cache-store.cc

  Log Message:
  -----------
  Show aws-sdk-cpp log messages


  Commit: 1c969611ba962a860744b2718fa6f989e7be5165
      
https://github.com/NixOS/nix/commit/1c969611ba962a860744b2718fa6f989e7be5165
  Author: Eelco Dolstra <edols...@gmail.com>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M src/libstore/s3-binary-cache-store.cc

  Log Message:
  -----------
  Suppress "will retry in N ms" for non-retriable errors

Newer versions of aws-sdk-cpp call CalculateDelayBeforeNextRetry()
even for non-retriable errors (like NoSuchKey) whih causes log spam in
hydra-queue-runner.


  Commit: b33621d4253addc4a0cdf1fb7a4082109aaafa78
      
https://github.com/NixOS/nix/commit/b33621d4253addc4a0cdf1fb7a4082109aaafa78
  Author: Eelco Dolstra <edols...@gmail.com>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M src/libstore/s3-binary-cache-store.cc

  Log Message:
  -----------
  Handle S3Errors::RESOURCE_NOT_FOUND from aws-sdk-cpp

This is returned by recent versions. Also handle NO_SUCH_KEY even
though the library doesn't actually return that at the moment.


  Commit: 82a0d614cf17b2997ba5f895c1db4c2cde41e88d
      
https://github.com/NixOS/nix/commit/82a0d614cf17b2997ba5f895c1db4c2cde41e88d
  Author: Eelco Dolstra <edols...@gmail.com>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M src/libstore/s3-binary-cache-store.cc

  Log Message:
  -----------
  Support creating S3 caches in other regions than us-east-1


  Commit: a1355917ecf75e1f1f37101505a351743d590121
      
https://github.com/NixOS/nix/commit/a1355917ecf75e1f1f37101505a351743d590121
  Author: Eelco Dolstra <edols...@gmail.com>
  Date:   2017-06-19 (Mon, 19 Jun 2017)

  Changed paths:
    M src/libstore/s3-binary-cache-store.cc

  Log Message:
  -----------
  Disable use of virtual hosting in aws-sdk-cpp

Recently aws-sdk-cpp quietly switched to using S3 virtual host URIs
(https://github.com/aws/aws-sdk-cpp/commit/69d9c53882), i.e. it sends
requests to http://<bucket>.<region>.s3.amazonaws.com rather than
http://<region>.s3.amazonaws.com/<bucket>. However this interacts
badly with curl connection reuse. For example, if we do the following:

1) Check whether a bucket exists using GetBucketLocation.
2) If it doesn't, create it using CreateBucket.
3) Do operations on the bucket.

then 3) will fail for a minute or so with a NoSuchBucket exception,
presumably because the server being hit is a fallback for cases when
buckets don't exist.

Disabling the use of virtual hosts ensures that 3) succeeds
immediately. (I don't know what S3's consistency guarantees are for
bucket creation, but in practice buckets appear to be available
immediately.)


Compare: https://github.com/NixOS/nix/compare/1888f7889b10...a1355917ecf7
_______________________________________________
nix-commits mailing list
nix-comm...@lists.science.uu.nl
https://mailman.science.uu.nl/mailman/listinfo/nix-commits

Reply via email to