Brian/Amol, I just applied the patch and everything works great. Thanks for your hard work!
Evan On 7/13/07, Evan Worley <[EMAIL PROTECTED]> wrote:
On a serious note, I will look into this patch this weekend. Thanks, Evan On 7/13/07, Evan Worley <[EMAIL PROTECTED] > wrote: > > hahaha, nice one Shane. I need to call my friends in the Seattle area > :) > > On 7/13/07, Shane Isbell < [EMAIL PROTECTED] > wrote: > > > > Evan just got setup with access. You could probably walk down the hall > > to > > nag him ;) > > > > On 7/13/07, Deacon, Brian <[EMAIL PROTECTED]> wrote: > > > > > > I'm not a committer. > > > > > > But let me add my nagging voice to try to get it committed. :) > > > > > > B > > > > > > -----Original Message----- > > > From: Amol Manjure [mailto:[EMAIL PROTECTED] ] > > > Sent: Friday, July 13, 2007 3:34 AM > > > To: [email protected] > > > Subject: Re: How to deal with resx from nmaven, and specifically > > from > > > the test plugin > > > > > > Hi Brian, > > > > > > Did you check this patch into SVN? I cannot locate it in any of the > > > branches or the trunk. > > > > > > Amol > > > > > > On 7/10/07, Deacon, Brian <[EMAIL PROTECTED] > wrote: > > > > Attached to NMAVEN-78. (With props to Amol!) > > > > > > > > B > > > > > > > > -----Original Message----- > > > > From: Shane Isbell [mailto: [EMAIL PROTECTED] > > > > Sent: Tuesday, July 10, 2007 9:53 AM > > > > To: [email protected] > > > > Subject: Re: How to deal with resx from nmaven, and specifically > > from > > > > the test plugin > > > > > > > > Go for it. > > > > > > > > On 7/10/07, Deacon, Brian <[EMAIL PROTECTED] > wrote: > > > > > > > > > > Besides solving my problem, this would seem to be useful > > > > > functionality > > > > > > > > > for a more straightforward issue like: > > > > > > > > > > <configuration> > > > > > <excludes> > > > > > <exclude>**/WeNeverTestClassesWithThisName.cs</exclude> > > > > > </excludes> > > > > > </configuration> > > > > > > > > > > Thoughts on including this as a patch? (He says as he gets > > ready to > > > > > > > > attach it as a patch to NMAVEN-78) > > > > > > > > > > B > > > > > > > > > > ________________________________ > > > > > > > > > > From: Amol Manjure [mailto: [EMAIL PROTECTED] ] > > > > > Sent: Tuesday, July 03, 2007 5:43 AM > > > > > To: [email protected] > > > > > Subject: Re: How to deal with resx from nmaven, and specifically > > > > > > > from the test plugin > > > > > > > > > > > > > > > I had a similar problem and have modified > > TestSourceProcessorMojo > > > > > and SourceProcessorMojo to read the excludes and testExcludes > > XML > > > > > nodes from the POM. Please find my version attached to this > > email. > > > > > The behavior is to use the hard coded excludes in the class and > > add > > > > > any excludes defined in the POM. > > > > > > > > > > The usage is similar to the maven-compiler-plugin. POM snippet > > below > > > > > > > > > > <snip> > > > > > <plugins> > > > > > <plugin> > > > > > <groupId>org.apache.maven.dotnet.plugins</groupId> > > > > > <artifactId>maven-compile-plugin</artifactId> > > > > > <extensions>true</extensions> > > > > > <configuration> > > > > > <excludes> > > > > > <exclude>**/*.xml</exclude> > > > > > <exclude>**/*.vspscc</exclude> > > > > > <exclude>**/*.config</exclude> > > > > > <exclude>**/*.bat</exclude> > > > > > <exclude>**/*.csproj*</exclude> > > > > > </excludes> > > > > > <testExcludes> > > > > > <exclude>**/*.xml</exclude> > > > > > <exclude>**/*.vspscc</exclude> > > > > > <exclude>**/*.config</exclude> > > > > > <exclude>**/*.bat</exclude> > > > > > <exclude>**/*.csproj*</exclude> > > > > > </testExcludes> > > > > > </configuration> > > > > > </plugin> > > > > > </plugins> > > > > > </snip> > > > > > > > > > > Amol > > > > > > > > > > > > > > > On 6/29/07, Shane Isbell <[EMAIL PROTECTED] > wrote: > > > > > > > > > > As a work-around, you can add the modify the > > > > > TestSourceProcessorMojo > > > > > (maven-compile-plugin) by adding the pattern to the > > exclude > > > > > list. > > > > > > > > > > excludeList.add ( "*.suo" ); > > > > > excludeList.add( "*.csproj" ); > > > > > excludeList.add( "*.sln" ); > > > > > excludeList.add( "obj/**" ); > > > > > > > > > > > > > > > On 6/28/07, Evan Worley <[EMAIL PROTECTED] > wrote: > > > > > > > > > > > > Hi Brian, > > > > > > > > > > > > There is a JIRA, http://jira.codehaus.org/browse/NMAVEN-78 > > > > > > > which is > > > > > > related. Essentially the test-plugin grabs everything > > as > > > > > a build test > > > > > > source instead of looking for only "test sources" > > > > > > > > > > > > -Evan > > > > > > > > > > > > On 6/28/07, Deacon, Brian <[EMAIL PROTECTED]> > > wrote: > > > > > > > > > > > > > > > So I've got this in build/plugins: > > > > > > > > <plugin> > > > > > > > > > > > > <groupId>org.apache.maven.dotnet.plugins</groupId> > > > > > > > > <artifactId>maven-test-plugin</artifactId> > > > > > > > > > > <version>0.14-SNAPSHOT</version> > > > > > > > > <extensions>true</extensions> > > > > > > > > <configuration> > > > > > > > > > > > > > > > > > > > > > <reportsDirectory>${basedir}/target/nunit-log</reportsDirectory> > > > > > > > > > > > > <compilerArgument>/debug:full</compilerArgument> > > > > > > > > </configuration> > > > > > > > > </plugin> > > > > > > > > > > > > > > > > But the csc call that gets made as a result when > > > > > trying to generate > > > > > > > > the test assembly has: > > > > > > > > /recurse:c:\blah\blah\target\build-test-sources\** > > > > > > > > > > > > > > > > > > So it's spitting out all kinds of syntax errors > > > > > because the test > > > > > > > > assembly contains .resx and other things that it > > is > > > > > trying to compile > > > > > > > > as c# content, which of course it isn't. > > > > > > > > > > > > > > > > Oh, and my only other settings in the <build> > > element > > > > are: > > > > > > > > > > > > > > > > <finalName>${artifactId}</finalName> > > > > > > > > > > <sourceDirectory>../src/dotnet</sourceDirectory> > > > > > > > > > > > > > <testSourceDirectory>../test/dotnet</testSourceDirectory> > > > > > > > > > > > > > > > > So, firstly, I need it to stop treating the > > resources > > > > > like source > > > > > > > > code, then secondly, I need it to actually compile > > > > > those > > > > > > > > > resources > > > > > > > > into the assembly. Anybody have the answer in > > their > > > > > back pocket? > > > > > > > > > > > > > > > > Brian > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
