This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The nmh Mail Handling System".
The branch, master has been updated via d247f1cf67f3e579ccddfa986c603dd91880cbe7 (commit) via 544d453bef5ccf734140f36efb1efd08ab8d71cb (commit) via edcbc70e11973f191f960a4102708b195dc378bf (commit) via af37e7c921540be0a53a0b6999f3d1cc95cc7527 (commit) via e35fb433456859d250d2e075350d11d4e173713b (commit) via 2d667ff62463f331fba7dddea084d1ededd24b71 (commit) via b04d3a5bfe54b5e828a998f3e56bd97d6f82df1d (commit) from e5479da8544d4fe47a320934667cb91c1c6a309e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d247f1cf67f3e579ccddfa986c603dd91880cbe7 Author: Ralph Corderoy <ra...@inputplus.co.uk> Date: Sun Sep 10 15:11:18 2017 +0100 find_cache(): Remove test that's always false. The if-statement's condition is a conjunctive that tests `!writing' and then, only if that's true, calls find_cache_aux() and tests `writing' in determining the first argument; that must be false. Bug pre-dates git history. commit 544d453bef5ccf734140f36efb1efd08ab8d71cb Author: Ralph Corderoy <ra...@inputplus.co.uk> Date: Sun Sep 10 15:03:09 2017 +0100 readline(3) wrapper: Move free(3) of line to where it's reachable. Every line returned by readline() has to be freed. The call to free() was unreachable because all paths heading towards it veered off, resulting in a memory leak. Move the free() to just after where the line has been used for the last time. Fixes 3a85e0bc9. commit edcbc70e11973f191f960a4102708b195dc378bf Author: Ralph Corderoy <ra...@inputplus.co.uk> Date: Sun Sep 10 14:53:32 2017 +0100 fmt_compile.c: Alter FINDCOMP(): the caller must supply the semicolon. The macro expands to a for-loop, including the semicolon body. The caller typically supplies their own semicolon. This results in two on one line that looks odd. Alter the macro to have the for-loop inside a do-while loop that doesn't have a semicolon, ensuring the caller must supply it. commit af37e7c921540be0a53a0b6999f3d1cc95cc7527 Author: Ralph Corderoy <ra...@inputplus.co.uk> Date: Sun Sep 10 14:44:15 2017 +0100 argsplit(): Incorrect type used in sizeof calculation for array. Switched to referring to the variable being assigned the resulting memory rather than duplicating its type information. Fixes 78211e93. commit e35fb433456859d250d2e075350d11d4e173713b Author: Ralph Corderoy <ra...@inputplus.co.uk> Date: Sun Sep 10 14:22:29 2017 +0100 get_file_info(): Flip logic throughout, reducing nesting. Now a series of small paragraphs, each of which might return on error. Also, the Cygwin oddity described in the comment needs no special handling given the recent bug fixes so it can be deleted. commit 2d667ff62463f331fba7dddea084d1ededd24b71 Author: Ralph Corderoy <ra...@inputplus.co.uk> Date: Sun Sep 10 13:38:18 2017 +0100 get_file_info(): Don't return filename from quote onwards on error. If `file_name' contained a quote then `cp' points to it, and remains pointing to it if any of concat(), popen(3), or fgets(3) fail to give the expected result. On returning, cp is not NULL and so strdup(cp) is returned. Also, if fgets() fails on Cygwin in the way the comment describes then cp is wrongly free(3)'d. (One of the problems with generic variable names is their overloaded semantics cause faulty re-use.) Fixes b4f2851d and 0c50c669. commit b04d3a5bfe54b5e828a998f3e56bd97d6f82df1d Author: Ralph Corderoy <ra...@inputplus.co.uk> Date: Sun Sep 10 13:29:46 2017 +0100 get_file_info(): Don't dereference out of scope char array. A pointer to `char buf[...]' is taken, the array being declared in a block scope inside the function. The pointer is passed to strdup(3) as the function returned, but the array is by then out of scope. Move the array to the function's scope. Fixes 0c50c669. ----------------------------------------------------------------------- Summary of changes: sbr/arglist.c | 2 +- sbr/fmt_compile.c | 11 ++-- sbr/mime_type.c | 88 +++++++++++++++----------------- sbr/read_switch_multiword_via_readline.c | 4 +- uip/mhcachesbr.c | 2 +- 5 files changed, 51 insertions(+), 56 deletions(-) hooks/post-receive -- The nmh Mail Handling System _______________________________________________ Nmh-commits mailing list Nmh-commits@nongnu.org https://lists.nongnu.org/mailman/listinfo/nmh-commits