On Fri, 22 Feb 2019 at 17:40, Edward d'Auvergne <[email protected]> wrote:
>
> On Fri, 22 Feb 2019 at 17:37, Stefano Luciano Ciurli
> <[email protected]> wrote:
> >
> > Hello,
> > I will deal with this issue immediately.
>
> Thank you. I'll fix this the way we always do this in relax - first
> I'll create a test to catch the error (in this case a GUI test), and
> then I'll fix the error. That way the bug can never return in the
> future. Cross linking to bug reports at
> https://sourceforge.net/p/nmr-relax/tickets/ is important for this.
Thank you! I've fixed this bug now in the commit:
https://sourceforge.net/p/nmr-relax/code/ci/75c3fcd4db8febab65cdbb7a26a7a84957150418/
The bug was a bit harder to catch than I expected, but it was
nevertheless caught in a new GUI test:
https://sourceforge.net/p/nmr-relax/code/ci/54fa28bbbf87f8d3402eed2aeee055ce26bbf035/
Before the fix, this resulted in the error message:
======================================================================
ERROR: test_bug_2_structure_read_pdb_failure
(test_suite.gui_tests.test_user_functions.User_functions)
Catch U{bug #2<https://sourceforge.net/p/nmr-relax/tickets/2/>}, the
failure of the structure.read_pdb user function.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/relax/relax/test_suite/gui_tests/test_user_functions.py",
line 84, in test_bug_2_structure_read_pdb_failure
uf.wizard._go_next(None)
File "/data/relax/relax/gui/wizards/wiz_objects.py", line 632, in _go_next
self._pages[self._current_page]._apply(event)
File "/data/relax/relax/gui/wizards/wiz_objects.py", line 166, in _apply
self.exec_status = self.on_execute()
File "/data/relax/relax/gui/uf_objects.py", line 941, in on_execute
return_status = self.execute(self.name, **kargs)
File "/data/relax/relax/gui/uf_objects.py", line 863, in execute
return_status = interpreter.apply(uf, *args, **kwds)
File "/data/relax/relax/gui/interpreter.py", line 109, in apply
fn(*args, **kwds)
File "/data/relax/relax/pipe_control/structure/main.py", line 1277,
in read_pdb
if not access(file_path, F_OK):
TypeError: coercing to Unicode: need string or buffer, NoneType found
----------------------------------------------------------------------
If you are able to use the git source code repository, or a snapshot
of it, then the bug will be gone. It will probably take me ~1 week
before I can make a quick 4.1.1 bug fix release.
Cheers,
Edward
_______________________________________________
nmr-relax-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nmr-relax-users
