Improper setting of length for _readableState.length in Readable streams api , may cause negative length
https://github.com/joyent/node/blob/v0.11.11-release/lib/_stream_readable.js#L354 should be changed to state.length -= ret ? ret.length : n . Because , when we call var ret = fromList(n,state)and when n > state.length in fromList function, the whole buffer is retrieved which might be less than value of n . So this might cause state.length be negative when n is sufficiently high which is set by user . So setting to to ret.length maybe more accurate ? I already posted this as a issue in github , but considering how rookie i am i hope someone can check it and verify -- -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en --- You received this message because you are subscribed to the Google Groups "nodejs" group. To unsubscribe from this group and stop receiving emails from it, send an email to nodejs+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
