I'm looking through the code trying to increase my understanding
of how fade-ins and fade-outs work. (Related to this issue:
https://github.com/original-male/non/issues/204).
Default fade-in and fade-out appear to both be set at 256 samples
in Audio_Region::init() in src/Audio_Region.C:
_fade_in.length = 256;
and
_fade_out = _fade_in;
De-click fades are set IIUC to 10ms in src/Engine/Audio_Region.C:
declick.length = (float)timeline->sample_rate() * 0.01f;
My tests related to issue #204 suggest that (when the bug is
triggered) declicks are being applied incorrectly on playback to
region starts and ends, even though there are already fades of at
least 256 samples there.
I'm assuming that since audio regions already have fades by
default, declicks are only needed when JACK transport starts or
stops. Is this correct?
John
