[ https://issues.apache.org/jira/browse/ACCUMULO-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771990#comment-13771990 ]
Keith Turner commented on ACCUMULO-1009: ---------------------------------------- I just spent a bit looking at a patch. And I see a new one was posted recently, these may be against the older one. It would be nice to post multiple version of the patch and then I could state that my comments are against version 002 of the patch. * what does certutils do that keytool does not? or does it just make things easier? How do you expect the user to run this? "accumulo org.apache.accumulo.server.security.ssl.CertUtils" ? If this is the case, then this utility is not front and center and the user would really have to look for it. * should generate all print a disclaimer clearly stating any potential pitfalls/risk the user should be aware of? [~ctubbsii] would this address your concern? * Adding ssl options to MAC is done to test Accumulo itself. However this will also be available to Accumulo users using MAC. Is this an API you feel comfortable supporting for a few years? * I am not in favor of adding "public ZooKeeperInstance(String instanceName, String zooKeepers, boolean sslEnabled)". This is not a scalable approach for configuring Accumulo. For example when ACCUMULO-1268 is implemented we would not want constructors for : (..., sslEnabled), (...,sslEnabled,timeout), (...,timeout) . I think the constructors that take ClientConfiguration are sufficient and ClientConfiguration looks nice, like it. I am kinda torn about making client and sever config follow differnt models, but the new client config seems better. I still need to look at it in more detail. * what needs to be done for the proxy w.r.t to ssl? should ClientConfiguration be exposed to proxy api? should proxy server support ssl? maybe we should create sub-tickets Seems like we need test for the following scenarios : * Server requires clients have cert signed by trusted CA (test client w/ valid cert, w/o cert, w/ invalid cert) * Server requires SSL, client tries connecting w/o SSL * Server does not have a cert that client trust * Multiple ZooKeeperInstances in the same java process with different SSL config (is this possible? It looks like you included ssl options in the Key in ThriftTransportPool?) This could happen if a single process connected to multiple Accumulo instances > Support encryption over the wire > -------------------------------- > > Key: ACCUMULO-1009 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1009 > Project: Accumulo > Issue Type: New Feature > Reporter: Keith Turner > Assignee: Michael Berman > Fix For: 1.6.0 > > Attachments: ACCUMULO-1009_thriftSsl.patch > > > Need to support encryption between ACCUMULO clients and servers. Also need > to encrypt communications between server and servers. > Basically need to make it possible for users to enable SSL+thrift. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira