[ 
https://issues.apache.org/jira/browse/ACCUMULO-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772119#comment-13772119
 ] 

Keith Turner commented on ACCUMULO-527:
---------------------------------------

The indentation of a few statements in shell.setInstance is incorrect, making 
it hard to read.  Should the code error if multiple options are given?  For 
example if -z, -zi, and -zh are given.  I suppose the existing code did not 
error if -z and --fake were specified.

I tried running the new unit test w/ eclemma and it showed no coverage in 
Shell... I wonder if this is because powermock.




                
> Shell should have way to specify instance name while using ZK hosts from 
> configuration
> --------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-527
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-527
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 1.4.1
>            Reporter: John Vines
>            Assignee: Bill Havanki
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.6.0
>
>         Attachments: 0001-ACCUMULO-527-Add-zi-and-zh-options-for-shell.patch
>
>
> Currently the shell uses HDFSZooInstance unless otherwise specified. It is 
> possible for a user to force a ZooInstance, in which case they specify a list 
> of ZKHosts and the instance name. However, there is no way to specify an 
> instance name and utilize the list of ZK hosts in the configuration file. We 
> should look into expanding the shell to include this creation option, 
> possibly by segregating the zookeeper hosts and instance name into two 
> seperate arguments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to