[ 
https://issues.apache.org/jira/browse/ACCUMULO-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806552#comment-13806552
 ] 

Michael Allen commented on ACCUMULO-1814:
-----------------------------------------

Here's a first pass at a patch.  It doesn't have quite as much testing as I'd 
like but time and tide seem to be working against me this weekend.  I'm happy 
to continue to refine this.  I think we should have some unit tests that 
involve encryption but those are a bit more involved to write (mostly because 
of the key management aspects).  

The basic thrust of the patch here is that the WALog format changed ever so 
slightly between 1.6.0 and 1.5.0, but enough that reading it caused problems.  
I consolidated the code that reads the headers out of the file into one spot in 
DFSLogger and had that spot return both the raw input stream and the decrypting 
input stream, both set to the right spot within the WALog to begin reading K/V 
pairs out of it.

Opinions welcome.

> LogSorter cannot read WAlogs from 1.5
> -------------------------------------
>
>                 Key: ACCUMULO-1814
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1814
>             Project: Accumulo
>          Issue Type: Bug
>          Components: tserver
>            Reporter: Eric Newton
>            Assignee: Michael Allen
>            Priority: Blocker
>             Fix For: 1.6.0
>
>         Attachments: ACCUMULO-1814.patch
>
>
> While working on the upgrade code for 1.6.0-SNAPSHOT, I got a version check 
> failure on reading a 1.5 WAL.
> Yikes!



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to