[ 
https://issues.apache.org/jira/browse/ACCUMULO-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924021#comment-13924021
 ] 

ASF subversion and git services commented on ACCUMULO-2429:
-----------------------------------------------------------

Commit 8acdf534ceb92627075a1417e61c5e14790ee9d8 in accumulo's branch 
refs/heads/master from [~bhavanki]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=8acdf53 ]

ACCUMULO-2429 Add shell shutdown for thread cleanup

The JLine 2 ConsoleReader used by Shell spawns a thread which should be cleaned 
up when
done with the Shell. Otherwise, the thread leaks, taking up resources when the 
shell is
used programmatically. This commit adds a shutdown() method to Shell for 
cleaning up the
thread. This enables ShellServerIT to pass reliably and not flood the OS with 
leaked
threads.


> Shell does not clean up JLine ConsoleReader, leaks threads
> ----------------------------------------------------------
>
>                 Key: ACCUMULO-2429
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2429
>             Project: Accumulo
>          Issue Type: Bug
>          Components: shell
>            Reporter: Bill Havanki
>            Assignee: Bill Havanki
>              Labels: memory-leak, shell, threads
>             Fix For: 1.6.0, 1.7.0
>
>
> The shell uses the JLine {{ConsoleReader}} class. That class spawns a thread 
> on construction (tsk-tsk) for its internal non-blocking input stream 
> representation. If the {{ConsoleReader}} is not shut down properly, the 
> thread keeps running. This is particularly a problem when running 
> {{ShellServerIT}} under 1.6 and later; the JVM can run out of memory to 
> allocate threads and fail the test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to