[
https://issues.apache.org/jira/browse/ACCUMULO-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062501#comment-14062501
]
Christopher Tubbs commented on ACCUMULO-2992:
---------------------------------------------
My main concern is that you were simply removing the use of
AccumuloConfiguration.getSiteConfiguration() because it was deprecated, and
SiteConfiguration wasn't. I'd probably argue that they both should have been,
because any SiteConfiguration we need for servers should be in server-base, not
in core. So, this seems like a lateral change, with no actual improvement to
the code. It's just exploiting an oversight in the fact that SiteConfiguration
hadn't been marked deprecated, and artificially removes deprecated code in
favor of other deprecated (but unmarked as such) code.
However, I'm fine with just a small javadoc comment in SiteConfiguration, and a
small inline comment for developers when it's called in the client code for
compatibility/convenience, so it doesn't drop off our radar completely. It's
certainly very low priority, I'd think. I wouldn't bother with an annotation.
That seems overkill (especially the annotation processor). I just think
developers reading the code should be aware of it.
> Eliminate (use of) AccumuloConfiguration.getSiteConfiguration()
> ---------------------------------------------------------------
>
> Key: ACCUMULO-2992
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2992
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Bill Havanki
> Assignee: Bill Havanki
> Priority: Trivial
> Labels: configuration
> Fix For: 1.6.1, 1.7.0
>
>
> The static method {{AccumuloConfiguration.getSiteConfiguration()}} has been
> deprecated for a long time. [~ecn] got rid of a lot of uses in ACCUMULO-2401.
> This ticket is to get rid of the rest. Each call can be replaced with:
> {code}
> SiteConfiguration.getInstance(DefaultConfiguration.getInstance());
> {code}
> The method itself can also be eliminated, as {{AccumuloConfiguration}} is not
> public API, assuming the elimination would not cause a problem.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
