[ https://issues.apache.org/jira/browse/ACCUMULO-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244455#comment-14244455 ]
Josh Elser edited comment on ACCUMULO-3402 at 12/12/14 5:14 PM: ---------------------------------------------------------------- Commenting here instead of on the review, because it's more a design issue than a code issue. Ed's comment on ACCUMULO-1242 [here|https://issues.apache.org/jira/browse/ACCUMULO-1242?focusedCommentId=13812208&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13812208] becomes relevant again. Initially I solved it by moving the classes out of core, but that apparently caused other issues. ;) Can we file a follow on to address that and improve how we handle logging in the MR classes again? Otherwise, the patch LGTM (although admittedly, I only skimmed it, since much of it looked like classes were just added/deleted/moved). was (Author: mdrob): Commenting here instead of on the review, because it's more a design issue than a code issue. Ed's comment on ACCUMULO-1424 [here|https://issues.apache.org/jira/browse/ACCUMULO-1242?focusedCommentId=13812208&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13812208] becomes relevant again. Initially I solved it by moving the classes out of core, but that apparently caused other issues. ;) Can we file a follow on to address that and improve how we handle logging in the MR classes again? Otherwise, the patch LGTM (although admittedly, I only skimmed it, since much of it looked like classes were just added/deleted/moved). > Introduction of the mapreduce maven module breaks 1.6 compatibility > ------------------------------------------------------------------- > > Key: ACCUMULO-3402 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3402 > Project: Accumulo > Issue Type: Bug > Components: client > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Blocker > Fix For: 1.7.0 > > > The introduction of mapreduce maven module breaks backwards compatibility > with 1.6. > Code that previously worked against 1.6 (that used our mapreduce classes) is > now broken without a deprecation cycle -- specifically trying to compile Hive > against Accumulo 1.7 is broken. > While the classes themselves haven't technically changed, the required > dependencies have. In my eyes, this is an incompatible change that violates > our current public API rules. -- This message was sent by Atlassian JIRA (v6.3.4#6332)