[ https://issues.apache.org/jira/browse/ACCUMULO-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Elser updated ACCUMULO-2510: --------------------------------- Fix Version/s: (was: 1.7.0) 1.7.1 1.8.0 > Consolidate references to an empty byte array > --------------------------------------------- > > Key: ACCUMULO-2510 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2510 > Project: Accumulo > Issue Type: Improvement > Affects Versions: 1.4.5, 1.5.2, 1.6.0 > Reporter: Sean Busbey > Priority: Minor > Labels: newbie > Fix For: 1.6.3, 1.8.0, 1.7.1 > > > We have tons of references to empty byte arrays, and even allocate some of > them dynamically. We should consolidate these to a single reference. > Personally, I think the constant should be somewhere that clients can use it > as well, because most of hte time I've done Accumulo work I've needed one. > But I don't feel strongly on this aspect. > Searching on current 1.6.0-SNAPSHOT: > {noformat} > busbey2-MBA:accumulo busbey$ grep -irl "{0}" * | grep ".java$" > core/src/main/java/org/apache/accumulo/core/client/admin/FindMax.java > core/src/main/java/org/apache/accumulo/core/client/impl/TabletLocatorImpl.java > core/src/main/java/org/apache/accumulo/core/data/KeyExtent.java > core/src/main/java/org/apache/accumulo/core/iterators/user/IndexedDocIterator.java > core/src/test/java/org/apache/accumulo/core/client/admin/FindMaxTest.java > core/src/test/java/org/apache/accumulo/core/iterators/user/IndexedDocIteratorTest.java > examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/KeyUtil.java > server/base/src/main/java/org/apache/accumulo/server/client/BulkImporter.java > server/base/src/main/java/org/apache/accumulo/server/util/Admin.java > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > busbey2-MBA:accumulo busbey$ grep -irl "byte\[0\]" * | grep ".java$" > core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java > core/src/main/java/org/apache/accumulo/core/client/security/tokens/PasswordToken.java > core/src/main/java/org/apache/accumulo/core/data/Column.java > core/src/main/java/org/apache/accumulo/core/data/Condition.java > core/src/main/java/org/apache/accumulo/core/data/Key.java > core/src/main/java/org/apache/accumulo/core/data/Mutation.java > core/src/main/java/org/apache/accumulo/core/data/Range.java > core/src/main/java/org/apache/accumulo/core/data/Value.java > core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java > core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Utils.java > core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java > core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyIterator.java > core/src/main/java/org/apache/accumulo/core/iterators/system/ColumnFamilySkippingIterator.java > core/src/main/java/org/apache/accumulo/core/iterators/user/IntersectingIterator.java > core/src/main/java/org/apache/accumulo/core/security/crypto/CryptoModuleFactory.java > core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java > core/src/test/java/org/apache/accumulo/core/client/mock/MockConnectorTest.java > core/src/test/java/org/apache/accumulo/core/client/mock/MockTableOperationsTest.java > core/src/test/java/org/apache/accumulo/core/data/ColumnTest.java > core/src/test/java/org/apache/accumulo/core/data/ConditionTest.java > core/src/test/java/org/apache/accumulo/core/data/KeyTest.java > core/src/test/java/org/apache/accumulo/core/data/OldMutation.java > core/src/test/java/org/apache/accumulo/core/file/rfile/BlockIndexTest.java > core/src/test/java/org/apache/accumulo/core/iterators/system/ColumnFilterTest.java > core/src/test/java/org/apache/accumulo/core/iterators/system/VisibilityFilterTest.java > core/src/test/java/org/apache/accumulo/core/iterators/user/CombinerTest.java > core/src/test/java/org/apache/accumulo/core/iterators/user/IndexedDocIteratorTest.java > core/src/test/java/org/apache/accumulo/core/iterators/user/IntersectingIteratorTest.java > core/src/test/java/org/apache/accumulo/core/iterators/user/RegExFilterTest.java > core/src/test/java/org/apache/accumulo/core/iterators/user/VisibilityFilterTest.java > core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java > core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java > examples/simple/src/main/java/org/apache/accumulo/examples/simple/dirlist/Ingest.java > examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataIngest.java > examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Index.java > examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Reverse.java > fate/src/main/java/org/apache/accumulo/fate/ZooStore.java > proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java > proxy/src/main/java/org/apache/accumulo/proxy/Util.java > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKAuthorizor.java > server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKPermHandler.java > server/base/src/main/java/org/apache/accumulo/server/tables/TableManager.java > server/base/src/main/java/org/apache/accumulo/server/tablets/UniqueNameAllocator.java > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > server/base/src/main/java/org/apache/accumulo/server/util/NamespacePropUtil.java > server/base/src/main/java/org/apache/accumulo/server/util/TablePropUtil.java > server/base/src/main/java/org/apache/accumulo/server/zookeeper/DistributedWorkQueue.java > server/master/src/main/java/org/apache/accumulo/master/Master.java > server/master/src/test/java/org/apache/accumulo/master/TestMergeState.java > server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java > server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java > test/src/main/java/org/apache/accumulo/test/continuous/ContinuousIngest.java > test/src/main/java/org/apache/accumulo/test/functional/CacheTestWriter.java > test/src/main/java/org/apache/accumulo/test/IMMLGBenchmark.java > test/src/main/java/org/apache/accumulo/test/randomwalk/security/SecurityFixture.java > test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/MapRedVerifyTool.java > test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Insert.java > test/src/main/java/org/apache/accumulo/test/TestBinaryRows.java > test/src/main/java/org/apache/accumulo/test/TestIngest.java > test/src/test/java/org/apache/accumulo/fate/zookeeper/ZooLockTest.java > test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java > test/src/test/java/org/apache/accumulo/test/functional/NativeMapIT.java > test/src/test/java/org/apache/accumulo/test/functional/SplitRecoveryIT.java > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)