[
https://issues.apache.org/jira/browse/ACCUMULO-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709811#comment-14709811
]
ASF GitHub Bot commented on ACCUMULO-3971:
------------------------------------------
Github user dhutchis commented on the pull request:
https://github.com/apache/accumulo/pull/44#issuecomment-134330086
Thanks for spotting that sentence Billie, will fix tonight. It's good to
throw in the rest of the Zipkin configuration as well (I was using the
default localhost and port).
On Mon, Aug 24, 2015 at 2:22 PM, billierinaldi <notificati...@github.com>
wrote:
> This looks great. Thanks, Dylan! I have two suggestions. One is about the
> sentence, "Span entries record full span information, whereas index and
> start time entries provide indexing into span information useful for
> quickly finding spans by type or start time." Actually both the span and
> start time entries have the full span information, while only the index
> entries provide indexing.
>
> The other suggestion is to mention other configuration properties that
> would need to be set for the zipkin span receiver in accumulo-site.xml and
> in the client configuration, such as:
>
> <property>
> <name>trace.span.receiver.zipkin.collector-hostname</name>
> <value>localhost</value>
> </property>
> <property>
> <name>trace.span.receiver.zipkin.collector-port</name>
> <value>9410</value>
> </property>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/accumulo/pull/44#issuecomment-134325576>.
>
> Better doc for tracing
> ----------------------
>
> Key: ACCUMULO-3971
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3971
> Project: Accumulo
> Issue Type: Improvement
> Components: docs, trace
> Affects Versions: 1.7.0
> Reporter: Dylan Hutchison
> Assignee: Dylan Hutchison
> Priority: Minor
> Labels: documentation
> Fix For: 1.7.1
>
>
> Developers who want to go beyond Accumulo's default tracing are too much on
> their own to figure out how to use Accumulo's tracing features. I had to
> dive deep into source code to figure out how to understand the trace table
> format and add a ZipkinSpanReceiver. I'd like to share what I found so that
> other developers do not have to to the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
