[
https://issues.apache.org/jira/browse/ACCUMULO-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082445#comment-15082445
]
Josh Elser commented on ACCUMULO-2493:
--------------------------------------
Ran this through Yetus for funsies:
Full console: https://paste.apache.org/d29E
{noformat}
+1 overall
____ _
/ ___| _ _ ___ ___ ___ ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
___) | |_| | (_| (_| __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
{noformat}
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 00s | The patch appears to include 11 new or
| | | | modified test files.
| +1 | mvninstall | 1m 58s | 1.7 passed
| +1 | compile | 1m 24s | 1.7 passed
| +1 | checkstyle | 1m 01s | 1.7 passed
| +1 | mvneclipse | 1m 06s | 1.7 passed
| +1 | findbugs | 3m 55s | 1.7 passed
| +1 | javadoc | 1m 17s | 1.7 passed
| +1 | mvninstall | 1m 28s | the patch passed
| +1 | compile | 1m 22s | the patch passed
| +1 | javac | 1m 22s | the patch passed
| +1 | checkstyle | 1m 03s | the patch passed
| +1 | mvneclipse | 1m 06s | the patch passed
| +1 | whitespace | 0m 00s | Patch has no whitespace issues.
| +1 | findbugs | 4m 09s | the patch passed
| +1 | javadoc | 1m 27s | the patch passed
| +1 | asflicense | 0m 36s | Patch does not generate ASF License
| | | | warnings.
| | | 22m 39s |
|| Subsystem || Report/Notes ||
============================================================================
| GITHUB PR | https://github.com/apache/accumulo/pull/61 |
| JIRA Issue | ACCUMULO-2493 |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Darwin hw10447.local 14.5.0 Darwin Kernel Version 14.5.0: Tue Sep 1
21:23:09 PDT 2015; root:xnu-2782.50.1~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality |
/usr/local/lib/yetus-0.1.0/lib/precommit/personality/Accumulo.sh |
| git revision | 1.7 / ff08336 |
| findbugs | v3.0.1 |
| modules | C: core server/base server/tracer shell U: . |
| Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
I do think I forgot to add the "run-tests" flag, however...
> BinaryFormatter needs to be refactored
> --------------------------------------
>
> Key: ACCUMULO-2493
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2493
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Reporter: Mike Drob
> Assignee: Matt Dailey
> Labels: newbie
> Fix For: 1.7.1, 1.8.0
>
>
> BinaryFormatter is currently used in a couple places in the shell, but the
> code is hard to read and understand. There is a static getlength, which is
> actually a setter, and all the instance calls end up going through
> unnecessary static methods.
> This combination makes it hard to reuse BinaryFormatter objects, or even use
> multiple, since the static state is likely to conflict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
