[ https://issues.apache.org/jira/browse/ACCUMULO-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163827#comment-15163827 ]
ASF GitHub Bot commented on ACCUMULO-4153: ------------------------------------------ Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/73#issuecomment-188458189 I apparently clicked through to the commit and left a bunch of comments instead of commenting on the PR itself. Sorry about that. Overall, this looks pretty good. Some nit-picky things on the test case (yay, tests!) and a similar recommendation to Marc's earlier note. > Change getCodec method in BCFile's Compression class > ---------------------------------------------------- > > Key: ACCUMULO-4153 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4153 > Project: Accumulo > Issue Type: Improvement > Components: core > Affects Versions: 1.6.5 > Reporter: marco polo > Assignee: marco polo > Priority: Minor > Fix For: 1.6.6, 1.7.2, 1.8.0 > > Attachments: patchCompression > > > Seeing major blockages blockages on the Synchronized method of getCodec. My > initial change was to change it to double checked locking; however, spoke > with [~kturner] and I'm changing this to an AtomicReference. Have a patch for > the former but am in the process of testing the AtomicReference patch > Note this is for Gzip -- This message was sent by Atlassian JIRA (v6.3.4#6332)