[ 
https://issues.apache.org/jira/browse/ACCUMULO-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241438#comment-15241438
 ] 

ASF GitHub Bot commented on ACCUMULO-4184:
------------------------------------------

Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/93#discussion_r59746357
  
    --- Diff: 
server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
 ---
    @@ -56,18 +61,24 @@
      * <b>table.custom.balancer.host.regex.pool.check=5m</b><br>
      * Regex matching can be based on either the host name (default) or host 
ip address. To set this balancer to match the regular expressions to the tablet 
server
      * IP address, then set the following property:<br>
    - * <b>table.custom.balancer.host.regex.is.ip=true</b>
    + * <b>table.custom.balancer.host.regex.is.ip=true</b><br>
    + * It's possible that this balancer may create a lot of migrations. To 
limit the number of migrations that are created during a balance call, set the 
following
    + * property (default 250):<br>
    + * <b>table.custom.balancer.host.regex.concurrent.migrations</b>
      *
      */
    -public class HostRegexTableLoadBalancer extends TableLoadBalancer {
    +public class HostRegexTableLoadBalancer extends TableLoadBalancer 
implements ConfigurationObserver {
     
       private static final Logger LOG = 
LoggerFactory.getLogger(HostRegexTableLoadBalancer.class);
       public static final String HOST_BALANCER_PREFIX = 
Property.TABLE_ARBITRARY_PROP_PREFIX.getKey() + "balancer.host.regex.";
    -  public static final String HOST_BALANCER_OOB_CHECK = 
Property.TABLE_ARBITRARY_PROP_PREFIX.getKey() + 
"balancer.host.regex.oob.period";
    +  public static final String HOST_BALANCER_OOB_CHECK_KEY = 
Property.TABLE_ARBITRARY_PROP_PREFIX.getKey() + 
"balancer.host.regex.oob.period";
    --- End diff --
    
    How many oobs does a host balancer have to check?  (in other words a more 
obvious property name might be nice).


> HostRegexTableLoadBalancer fixup
> --------------------------------
>
>                 Key: ACCUMULO-4184
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4184
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: master
>            Reporter: Dave Marion
>            Assignee: Dave Marion
>             Fix For: 1.7.2, 1.8.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Ticket to address issues with the new balancer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to