[
https://issues.apache.org/jira/browse/ACCUMULO-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shawn Walker updated ACCUMULO-4191:
-----------------------------------
Status: Patch Available (was: Open)
diff --git
a/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
b/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
index 459d230..2880047 100644
---
a/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
+++
b/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
@@ -733,7 +733,7 @@ public class TabletServerBatchWriter {
void queueMutations(final MutationSet mutationsToSend) throws
InterruptedException {
if (null == mutationsToSend)
return;
- binningThreadPool.execute(new Runnable() {
+ binningThreadPool.execute(Trace.wrap(new Runnable() {
@Override
public void run() {
@@ -746,7 +746,7 @@ public class TabletServerBatchWriter {
}
}
}
- });
+ }));
}
private void addMutations(MutationSet mutationsToSend) {
> Tracing on client can sometimes lose "sendMutations" events.
> ------------------------------------------------------------
>
> Key: ACCUMULO-4191
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4191
> Project: Accumulo
> Issue Type: Bug
> Reporter: Shawn Walker
> Assignee: Shawn Walker
> Priority: Minor
>
> In {{TabletServerBatchWriter.MutationWriter.queueMutations(...)}} (line 736),
> HTrace {{Span}}'s are not properly propagated across thread boundaries.
> Consequently, tracing doesn't propagate into
> {{TabletServerBatchWriter.SendTask.send(...)}}, and so the {{sendMutation}}
> event is not logged.
> This can cause {{ShellServerIT.trace(...)}} to fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
