[
https://issues.apache.org/jira/browse/ACCUMULO-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244438#comment-15244438
]
Billie Rinaldi commented on ACCUMULO-4192:
------------------------------------------
Yeah, I kind of gathered that, I just wanted to provide some context as to why
it was removed. Adding Trace.wrap for individual Runnables or using
TraceExecutorService to wrap a thread pool would be fine. The problem that was
fixed was that a Runnable that stays around for the entire life of the thread
pool was being wrapped, instead of wrapping individual tasks executed by the
pool. I started a list of areas we might want to examine in the description of
that ticket (things I thought might be affected by the change).
> Analyze Threading for Tracing correctness
> -----------------------------------------
>
> Key: ACCUMULO-4192
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4192
> Project: Accumulo
> Issue Type: Task
> Components: trace
> Reporter: Josh Elser
> Priority: Blocker
> Fix For: 1.7.2, 1.8.0
>
>
> When we switched from cloudtrace to htrace, we lost an implicit
> {{TraceRunnable}} wrapper in NamingThreadFactory (which is used by
> SimpleThreadPool). This results in the current Trace's span being lost across
> threads.
> We should inspect uses of SimpleThreadPool (and maybe TraceRunnable in 1.6)
> to make sure that we don't have any other hidden tracing problems before the
> next 1.7 and 1.8 release.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
