[ 
https://issues.apache.org/jira/browse/ACCUMULO-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864571#comment-15864571
 ] 

Keith Turner commented on ACCUMULO-4586:
----------------------------------------

{quote}
The proposed "fix" removes a perfectly valid use of RowIterator, changing the 
behavior to favor a different use case.
{quote}

I looked at the javadoc for RowIterator and it does not specify that sorted 
data is expected.  Therefore using it with unsorted data may be a valid use 
case.  If someone were relying on that behavior, I would not want to change the 
behavior in a bug fix release.  

I still want to help users who are unaware of all of these subtleties in some 
way.  At the very least we can improve the javadocs for now to make the 
potential issues with the batch scanner clear.

{quote}
I would prefer a new, alternate API to replace it, which imposes the desired 
restrictions.
{quote}

Could introduce a new class in 2.0 and deprecate the current one.  The new 
class could have javadocs and strict checks for sorted order.  The new class 
could possibly be an Iterable instead of Iterator.


> Make rowiterator fail when unsorted data is observed
> ----------------------------------------------------
>
>                 Key: ACCUMULO-4586
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4586
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.6, 1.7.1, 1.8.0
>            Reporter: Keith Turner
>             Fix For: 2.0.0
>
>
> A batchscanner was used as a row iterator data source.  The rowiterator 
> expects data in sorted order and the batch scanner does not supply data in 
> sorted order.  The row iterator should have a sanity check to ensure source 
> data is in sorted order.
> https://lists.apache.org/thread.html/c24448d171d8414321bccfc778c7fc8b53e45892cae9daafa220503f@%3Cuser.accumulo.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to