ctubbsii commented on a change in pull request #300: ACCUMULO-4708 Limit RFile 
block size to 2GB
URL: https://github.com/apache/accumulo/pull/300#discussion_r139434688
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
 ##########
 @@ -426,6 +426,10 @@ public void append(Key key, Value value) throws 
IOException {
         throw new IllegalArgumentException("Keys appended out-of-order.  New 
key " + key + ", previous key " + prevKey);
       }
 
+      if ((long) ((long) key.getSize() + (long) value.getSize()) >= 
Integer.MAX_VALUE) {
 
 Review comment:
   Same comment about casts.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to