keith-turner commented on a change in pull request #300: ACCUMULO-4708 Limit 
RFile block size to 2GB
URL: https://github.com/apache/accumulo/pull/300#discussion_r139749197
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
 ##########
 @@ -118,6 +118,9 @@ private RFile() {}
   // Buffer sample data so that many sample data blocks are stored 
contiguously.
   private static int sampleBufferSize = 10000000;
 
+  // 5 bytes of overhead for fields: value, row, colFamily, colQualifier, 
colVisibility, and 8 for the timestamp
 
 Review comment:
   would nice to mention what the overhead is... its worst case serialization 
overhead
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to