keith-turner commented on a change in pull request #302: ACCUMULO-2968: Axe TabletServer.majorCompactorDisabled URL: https://github.com/apache/accumulo/pull/302#discussion_r142532833
########## File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactionRunner.java ########## @@ -34,12 +34,9 @@ public CompactionRunner(Tablet tablet, MajorCompactionReason reason) { @Override public void run() { - if (tablet.getTabletServer().isMajorCompactionDisabled()) { - // this will make compaction tasks that were queued when shutdown was - // initiated exit - tablet.removeMajorCompactionQueuedReason(reason); - return; - } + // ACCUMULO-2968: isMajorCompactionDisabled() previously always returned false. Review comment: I think this comment can be omitted ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services