keith-turner commented on a change in pull request #313: ACCUMULO-4726 Add Value.contentEquals(byte[]) method URL: https://github.com/apache/accumulo/pull/313#discussion_r147469254
########## File path: core/src/main/java/org/apache/accumulo/core/data/Value.java ########## @@ -242,16 +242,16 @@ public int compareTo(final byte[] that) { @Override public boolean equals(Object right_obj) { - // compare with byte[] for backwards compatibility, but this is generally a pretty bad practice - if (right_obj instanceof byte[]) { - return compareTo((byte[]) right_obj) == 0; Review comment: I am ok with making this change (w/o the exception), since the behavior was not documented. Thinking about it some more there are potential negative consequences with making the change and not making the change. I have no idea which will be most beneficial overall. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services