jomach commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r153409112
##########
File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
##########
@@ -354,12 +354,8 @@ public void run() {
}
private static void stopServer(final ClientContext context, final boolean
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
- MasterClient.executeVoid(context, new
ClientExec<MasterClientService.Client>() {
- @Override
- public void execute(MasterClientService.Client client) throws Exception {
- client.shutdown(Tracer.traceInfo(), context.rpcCreds(),
tabletServersToo);
- }
- });
+ MasterClient.executeVoidWithConnRetry(context,
Review comment:
What if we leave this method as it is (before my commit) and create a new
one named for example MasterClient.getConnectionForShutdown(context) this will
try two times and return null if it is not possible. This would avoid setting
and defining timeouts (For example if some network problem is there for a few
hours depending on the time would break things.)
Another question would be: What is a reasonable Timout to set ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
