ctubbsii commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154791885
 
 

 ##########
 File path: 
core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java
 ##########
 @@ -183,4 +193,13 @@ public static void executeVoid(ClientContext context, 
ClientExec<MasterClientSer
       throw new AssertionError(e);
     }
   }
+
+  public static void executeVoidAdmin(ClientContext context, 
ClientExec<MasterClientService.Client> exec) throws AccumuloException, 
AccumuloSecurityException {
 
 Review comment:
   Maybe call this `executeVoidWithTimeout`? Again, passing timeout here, and 
then down through, would be helpful. The timeout used for `Admin.java` should 
be a constant in that class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to