ctubbsii commented on issue #369: [ACCUMULO-4787] Close input stream in AccumuloReplicaSystem URL: https://github.com/apache/accumulo/pull/369#issuecomment-361139353 > why did findbugs not catch this? Probably because the resource is being allocated by a method... like a factory pattern. Unclosed resources allocated that way are difficult to track. It probably shows up in Eclipse as "potential resource leak", but that warning is usually suppressed with default Eclipse settings, because it's pretty spammy and full of false positives, because Java does not have a good way to track resource from factories.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
