mikewalch commented on a change in pull request #382: ACCUMULO-4782 switch session manager to a concurrent map URL: https://github.com/apache/accumulo/pull/382#discussion_r168276211
########## File path: server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java ########## @@ -70,20 +84,20 @@ public void run() { }; SimpleTimer.getInstance(conf).schedule(r, 0, Math.max(maxIdle / 2, 1000)); + } - public synchronized long createSession(Session session, boolean reserve) { + public long createSession(Session session, boolean reserve) { Review comment: Might be nice to have an initial state for Sessions and check that it is in that state here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services