mikewalch commented on a change in pull request #378: ACCUMULO-4800 Cache
parsing of iterator config
URL: https://github.com/apache/accumulo/pull/378#discussion_r168859266
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java
##########
@@ -186,12 +188,28 @@ public boolean isCurrent() {
if (!loadIters) {
return visFilter;
- } else if (null == options.getClassLoaderContext()) {
- return
iterEnv.getTopLevelIterator(IteratorUtil.loadIterators(IteratorScope.scan,
visFilter, tablet.getExtent(), tablet.getTableConfiguration(),
- options.getSsiList(), options.getSsio(), iterEnv));
} else {
- return
iterEnv.getTopLevelIterator(IteratorUtil.loadIterators(IteratorScope.scan,
visFilter, tablet.getExtent(), tablet.getTableConfiguration(),
- options.getSsiList(), options.getSsio(), iterEnv, true,
options.getClassLoaderContext()));
+ List<IterInfo> iterInfos;
+ Map<String,Map<String,String>> iterOpts;
Review comment:
Can you describe what is going on in this block?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
