jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override
Annotations
URL: https://github.com/apache/accumulo/pull/476#discussion_r186537462
##########
File path: pom.xml
##########
@@ -1776,6 +1776,41 @@
<findbugs.excludeFilterFile>src/main/findbugs/exclude-filter.xml</findbugs.excludeFilterFile>
</properties>
</profile>
+ <profile>
+ <id>overrides</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <compilerId>javac-with-errorprone</compilerId>
+ <forceJavacCompilerUse>true</forceJavacCompilerUse>
+ <source>1.8</source>
+ <target>1.8</target>
+ <compilerArgs>
+ <arg>-XepDisableAllChecks</arg>
+ <arg>-Xep:MissingOverride:ERROR</arg>
+
<arg>-XepExcludedPaths:.*/(proto|thrift|generated-sources)/.*</arg>
Review comment:
Looking a little more into this, I'm not sure that is going to be
sufficient. I re-ran using the XepDisableWarningsInGeneratedCode and the
TRange.java file was flagged for multiple violations. But when I examined the
file, it contains the expected annotation (@javax.annotation.Generated) and
still gets flagged. Not sure if there is some buggy behavior in errorprone or
if something else going on. Noticed the same behavior in a couple of more
files. I may try search the web later and see if I find any info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
