mikewalch commented on a change in pull request #549:  ACCUMULO-4074 Added 
support for multiple scan executors
URL: https://github.com/apache/accumulo/pull/549#discussion_r200711953
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -430,12 +433,33 @@
       "When a tablet server's SimpleTimer thread triggers to check idle"
           + " sessions, this configurable option will be used to evaluate 
update"
           + " sessions to determine if they can be closed due to inactivity"),
+  @Deprecated
   TSERV_READ_AHEAD_MAXCONCURRENT("tserver.readahead.concurrent.max", "16", 
PropertyType.COUNT,
-      "The maximum number of concurrent read ahead that will execute. This 
effectively"
-          + " limits the number of long running scans that can run 
concurrently per tserver."),
+      "This property is deprecated, use tserver.scan.executors.default.threads 
instead."),
+  @Deprecated
   
TSERV_METADATA_READ_AHEAD_MAXCONCURRENT("tserver.metadata.readahead.concurrent.max",
 "8",
       PropertyType.COUNT,
-      "The maximum number of concurrent metadata read ahead that will 
execute."),
+      "This property is deprecated, use tserver.scan.executors.meta.threads 
instead."),
+  TSERV_SCAN_EXECUTORS_PREFIX("tserver.scan.executors.", null, 
PropertyType.PREFIX,
+      "Prefix for defining executors to service scans.  For each executor the 
number of threads, "
 
 Review comment:
   The documentation here is nice but it would be help if a page was added to 
the Accumulo user manual about scan executors.  This page could:
   * Describe motivation for scan executors
   * Document default behavior for scan executors
   * Document how scan executors can be used w/o using a custom scan dispactcher
   * When/how to write custom scan dispatcher and prioritizer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to