ctubbsii commented on a change in pull request #733: Add AutoClosable for
MiniAccumuloCluster
URL: https://github.com/apache/accumulo/pull/733#discussion_r229311113
##########
File path:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloCluster.java
##########
@@ -167,4 +167,9 @@ public static ClientInfo getClientInfo(File directory) {
Preconditions.checkArgument(clientProps.exists());
return
Accumulo.newClient().usingProperties(clientProps.getAbsolutePath()).info();
}
+
+ @Override
+ public void close() throws Exception {
Review comment:
I think it'd be better if this threw a more narrow exception, or didn't
throw any checked exceptions at all (just RTEs).
Also, this is API, so we need to add inherit the parent javadoc and add a
`@since 2.0.0` tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
