ctubbsii opened a new issue #1090: Consolidate/Simplify ServerOpts
URL: https://github.com/apache/accumulo/issues/1090
 
 
   Most server types use the same set of options, but the 
SimpleGarbageCollector has two additional options which can be removed:
   
   1. `verbose` - This prints to the console, but this should be entirely 
controlled by log4j settings. We do not need a custom command-line flag to 
print to the log AND the console, when the logging settings already have the 
capability to print specific log categories to different destinations.
   2. `safeMode` - This should be an option that is possible to set in the 
configuration file. All configuration file options should be able to be 
specified on the command-line to override the config file.
   
   In addition, ServerOpts trivially extends ConfigOpts, and is not needed. 
ServerOpts provides only the `address` option. However, this should also be 
configurable in the file, and override-able on the command-line. There is no 
need for a separate option only available on the command-line. Furthermore, 
when this is added to the config file, its behavior should be more well-defined 
(in other words, should this be the service advertisement address, or the bind 
address? currently, I believe it is both, but they should be configurable 
separately).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to