ctubbsii commented on a change in pull request #1381: Update gc metrics
reporting to use hadoop metrics2
URL: https://github.com/apache/accumulo/pull/1381#discussion_r331296223
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -529,8 +529,9 @@
"When the gc runs it can make a lot of changes to the metadata, on
completion, "
+ " to force the changes to be written to disk, the metadata and
root tables can be flushed"
+ " and possibly compacted. Legal values are: compact - which both
flushes and compacts the"
- + " metadata; flush - which flushes only (compactions may be
triggered if required); or none."
- + " Since 2.0, the default is flush. Previously the default action
was a full compaction."),
+ + " metadata; flush - which flushes only (compactions may be
triggered if required); or none"),
+ GC_ENABLE_METRICS2("gc.enable.metrics2", "true", PropertyType.BOOLEAN,
Review comment:
I think the following name change would make the property more consistent
with similar props:
```suggestion
GC_METRICS_ENABLED("gc.metrics.enabled", "true", PropertyType.BOOLEAN,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
