ctubbsii commented on a change in pull request #1450: #1373: Preferred volume chooser support the init scope fix URL: https://github.com/apache/accumulo/pull/1450#discussion_r355067481
########## File path: server/base/src/main/java/org/apache/accumulo/server/fs/InitVolumeChooserEnvironmentImpl.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.server.fs; + +import java.io.IOException; + +import org.apache.accumulo.core.conf.AccumuloConfiguration; +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.core.spi.common.ServiceEnvironment; +import org.apache.accumulo.server.ServiceEnvironmentImpl; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.io.Text; + +public class InitVolumeChooserEnvironmentImpl implements VolumeChooserEnvironment { Review comment: Three alternatives/variations to consider (if you haven't already) instead of having this class as-is: 1. Could make this extend VolumeChooserEnvironmentImpl, and only override those methods that are necessary, 2. Could make this an anonymous inner class inside Initialize, and 3. Could move this class to the init package, since it's an init-specific class. Some of these variations could be combined. In any case, I think some of this comes down to personal-preference/style. It's fine as-is (other comments aside). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
