milleruntime commented on a change in pull request #1536: Improve master
metrics rported via hadoop metrics
URL: https://github.com/apache/accumulo/pull/1536#discussion_r385740458
##########
File path:
server/master/src/main/java/org/apache/accumulo/master/metrics/fate/FateLegacyJMXMetricsMBean.java
##########
@@ -16,12 +16,12 @@
*/
package org.apache.accumulo.master.metrics.fate;
-public interface FateMetricsMBean {
+public interface FateLegacyJMXMetricsMBean {
Review comment:
Since a lot of these legacy classes were removed in 2.x, I am not sure how
productive it is to refactor them. If it helps to differentiate between the
legacy and the Hadoop2 metrics then I guess it is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services