keith-turner commented on a change in pull request #1537: Add PrintInfo options
to dump full keys, apply formatter
URL: https://github.com/apache/accumulo/pull/1537#discussion_r385918778
##########
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java
##########
@@ -49,6 +59,12 @@
static class Opts extends Help {
@Parameter(names = {"-d", "--dump"}, description = "dump the key/value
pairs")
boolean dump = false;
+ @Parameter(names = {"--fullKeys"},
+ description = "dump full keys regardless of length, do no truncate,
implies --dump")
+ boolean fullKeys = false;
+ @Parameter(names = {"--formatter"},
+ description = "specify a formatter class to apply to rfile contents,
implies --dump")
Review comment:
The formatter class is a bit of a mess. What do you think about accepting
any class that implements `BiFunction<Key, Value, String>`? If you have a
strong need specifically for the formatter, please ignore the comments related
to BiFunction
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
