ctubbsii commented on a change in pull request #1771:
URL: https://github.com/apache/accumulo/pull/1771#discussion_r520262824
##########
File path:
shell/src/main/java/org/apache/accumulo/shell/commands/InsertCommand.java
##########
@@ -171,6 +180,11 @@ public Options getOptions() {
"durability to use for insert, should be one of \"none\" \"log\"
\"flush\" or \"sync\"");
o.addOption(durabilityOption);
+ tableNameOption =
+ new Option("", "tablename", true, "name of table in which data is
being inserted");
+ tableNameOption.setArgName("tablename");
+ o.addOption(tableNameOption);
+
Review comment:
If there's not already a `-t`, I don't think it's a problem. I don't
think there's any concern over conflicting with `-ts`. In fact, most commands
use the standard `OptUtil.tableOpt`. See
https://github.com/apache/accumulo/blob/main/shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java#L93
and
https://github.com/apache/accumulo/blob/main/shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java#L395.
I would recommend doing the same here, if there's no existing `-t`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
