Manno15 edited a comment on pull request #1824:
URL: https://github.com/apache/accumulo/pull/1824#issuecomment-754822950


   I believe this pull request is ready for review. There are a couple of areas 
where I unsure of the proper route to go on. One is the use of `DumbTerminal` 
in 
[ShellIT](https://github.com/apache/accumulo/blob/61a1755547fc0f9fd6290eb4abe704b775657618/test/src/main/java/org/apache/accumulo/test/ShellIT.java#L166)
 and 
[ShellServerIT](https://github.com/Manno15/accumulo/blob/61a1755547fc0f9fd6290eb4abe704b775657618/test/src/main/java/org/apache/accumulo/test/ShellServerIT.java#L198).
 The other concern is 
[here](https://github.com/apache/accumulo/blob/61a1755547fc0f9fd6290eb4abe704b775657618/shell/src/main/java/org/apache/accumulo/shell/Shell.java#L563)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to