milleruntime commented on a change in pull request #1968:
URL: https://github.com/apache/accumulo/pull/1968#discussion_r597842565
##########
File path:
core/src/main/java/org/apache/accumulo/core/crypto/CryptoServiceFactory.java
##########
@@ -56,11 +96,50 @@ public static CryptoService
newInstance(AccumuloConfiguration conf, ClassloaderT
throw new IllegalArgumentException();
}
-
newCryptoService.init(conf.getAllPropertiesWithPrefix(Property.INSTANCE_CRYPTO_PREFIX));
- return newCryptoService;
+ var encrypter = newCryptoService.getEncrypter();
+ encrypter.init(initParams);
+ return encrypter;
}
- public static CryptoService newDefaultInstance() {
- return newInstance(DefaultConfiguration.getInstance(),
ClassloaderType.JAVA);
+ public static List<CryptoService> getDecrypters(AccumuloConfiguration conf,
ClassloaderType ct) {
+ String[] classes = conf.get(TABLE_CRYPTO_DECRYPT_SERVICES).split(",");
Review comment:
That isn't a bad idea. I was going with the approach that if the decrypt
service isn't in the config that we won't load it. Another option would be to
make it flexible by adding the encrypt service to the list of decrypters if it
isn't present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
