ctubbsii commented on a change in pull request #1971:
URL: https://github.com/apache/accumulo/pull/1971#discussion_r598954287
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java
##########
@@ -96,6 +96,7 @@
private ClientInfo info;
private String instanceId;
private final ZooCache zooCache;
+ private static final String VALID_NAME_REGEX =
"^(\\w{1,1024}\\.)?(\\w{1,1024})$";
Review comment:
@slackwinner You are correct that `{1,1024}` enforces the length
constraint.
I think those integer constants in `Constants.java` can be deleted in favor
of the regex constant you are adding that enforces the length constraint and
other naming restrictions all in a single place. We don't need a constant
inside a constant. We can just have the one regex, and if things change later,
we can change the regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
