slackwinner commented on a change in pull request #2075:
URL: https://github.com/apache/accumulo/pull/2075#discussion_r628151713
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientInfoImpl.java
##########
@@ -115,6 +120,18 @@ public static Properties toProperties(Path propertiesFile)
{
return properties;
}
+ @SuppressFBWarnings(value = "URLCONNECTION_SSRF_FD",
+ justification = "code runs in same security context as user who provided
propertiesURL")
+ public static Properties toProperties(URL propertiesURL) {
+ Properties properties = new Properties();
+ try (InputStream is = propertiesURL.openStream()) {
Review comment:
Well I was thinking we can ensure the URL contains a properties
extension before executing load() to achieve fast failure in case a user
accidentally passes in the wrong URL (e.g. The user sends in a URL that leads
to a text file). However if load() already provides the fast failure feature,
we could forgo the parameter sanitation all together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
