[
https://issues.apache.org/jira/browse/ACCUMULO-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeffrey Manno resolved ACCUMULO-2987.
-------------------------------------
Resolution: Not A Problem
The shell scripts have changed dramatically since this ticket was originally
created. Most of these issues have been resolved. The shell check warnings have
been handled in PR [https://github.com/apache/accumulo/pull/2133.
|https://github.com/apache/accumulo/pull/2133/]
> Verify that all shell scripts read role files consistently
> ----------------------------------------------------------
>
> Key: ACCUMULO-2987
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2987
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
> Reporter: Mike Drob
> Priority: Major
>
> We rely on role files to determine proper behaviour in several of our
> scripts. However, we are inconsistent in how we parse these files, sometimes
> using cat, other times grep to drop blank lines and yet other times dropping
> lines that begin with {{#}}.
> Also, as noted in the review for ACCUMULO-2423, shellcheck warns that:
> {quote}
> for f in $(grep -v '^#' "$ACCUMULO_CONF_DIR/masters")
> ^-- SC2013: To read lines rather than words, pipe/redirect to a
> 'while read' loop.
> {quote}
> We should verify correctness of all of these invocations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
