Manno15 commented on a change in pull request #2309:
URL: https://github.com/apache/accumulo/pull/2309#discussion_r727245451
##########
File path:
core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionMetadata.java
##########
@@ -54,6 +54,12 @@ public ExternalCompactionMetadata(Set<StoredTabletFile>
jobFiles, Set<StoredTabl
TabletFile compactTmpName, String compactorId, CompactionKind kind,
short priority,
CompactionExecutorId ceid, boolean propagateDeletes, boolean
initiallySelectedAll,
Long compactionId) {
+ if (!initiallySelectedAll && !propagateDeletes
+ && (kind == CompactionKind.SELECTOR || kind == CompactionKind.USER)) {
+ throw new IllegalArgumentException(
+ "When a user or selector compactions does not propgates deletes, its
expected that all "
+ + "files were selected initially.");
Review comment:
```suggestion
throw new IllegalArgumentException(
"When user or selector compactions do not propagate deletes, it's
expected that all "
+ "files were selected initially.");
```
This could probably be further reworded to make it easier to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
