milleruntime commented on a change in pull request #2318:
URL: https://github.com/apache/accumulo/pull/2318#discussion_r739193838
##########
File path:
core/src/main/java/org/apache/accumulo/core/util/compaction/ExternalCompactionUtil.java
##########
@@ -191,29 +227,28 @@ private static ExternalCompactionId
getRunningCompactionId(HostAndPort compactor
* server context
* @return map of compactor and external compaction jobs
*/
- public static Map<HostAndPort,TExternalCompactionJob>
- getCompactionsRunningOnCompactors(ClientContext context) {
-
- final List<Pair<HostAndPort,Future<TExternalCompactionJob>>> running = new
ArrayList<>();
+ public static List<RunningCompaction>
getCompactionsRunningOnCompactors(ClientContext context) {
+ final List<RunningCompactionFuture> rcFutures = new ArrayList<>();
Review comment:
Hmm OK I will have to try those. Getting a client connection to the
Coordinator makes more sense too. I am not sure the thrift type
`TExternalCompactionList` returned will be as user friendly as the
`RunningCompaction` object I moved into core. One thing I noticed just looking
is that `java.util.Map<java.lang.Long,TCompactionStatusUpdate> updates` might
be better as a TreeMap. Does Thrift provide a `TreeMap` type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
