ctubbsii commented on a change in pull request #2335:
URL: https://github.com/apache/accumulo/pull/2335#discussion_r739530060
##########
File path:
server/tserver/src/test/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystemTest.java
##########
@@ -55,16 +55,15 @@
import org.apache.accumulo.tserver.logger.LogEvents;
import org.apache.accumulo.tserver.logger.LogFileKey;
import org.apache.accumulo.tserver.logger.LogFileValue;
-import
org.apache.accumulo.tserver.replication.AccumuloReplicaSystem.ReplicationStats;
-import
org.apache.accumulo.tserver.replication.AccumuloReplicaSystem.WalClientExecReturn;
-import
org.apache.accumulo.tserver.replication.AccumuloReplicaSystem.WalReplication;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.io.Text;
import org.junit.Test;
+@SuppressWarnings("deprecation")
public class AccumuloReplicaSystemTest {
Review comment:
I think if you deprecate this test class, you don't need to suppress
deprecations or deprecate individual methods.
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/AccumuloClient.java
##########
@@ -323,6 +323,7 @@ ConditionalWriter createConditionalWriter(String tableName,
ConditionalWriterCon
*
* @return an object to modify replication configuration
*/
+ @Deprecated
Review comment:
I think we can add a `since = "2.1.0"` here. (new optional parameter in
Java 9)
This could be done for any public API and property deprecations. I wouldn't
bother doing this with internal deprecations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
