ctubbsii commented on a change in pull request #2337:
URL: https://github.com/apache/accumulo/pull/2337#discussion_r740419236
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
##########
@@ -763,7 +763,7 @@ public void run() {
log.trace("{} - binning {} mutations",
Thread.currentThread().getName(),
mutationsToSend.size());
addMutations(mutationsToSend);
- } catch (Exception e) {
+ } catch (Throwable e) {
updateUnknownErrors("Error processing mutation set", e);
Review comment:
This change very dangerously allows the JVM to continue working as
though nothing serious happened when an Error occurred, and that is not a good
idea. This pattern of behavior was addressed in newer versions in #1840 . While
1.10 still has that behavior throughout, I think this moves it further in the
direction away from where we are headed with 2.1. I'm not sure what a better
solution would be, but I wouldn't want the JVM to continue processing mutations
as though nothing was wrong, if there were an Error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
