dlmarion commented on pull request #2340: URL: https://github.com/apache/accumulo/pull/2340#issuecomment-959209736
> If the goal of this change is to make it so that Accumulo client code never has to catch Error This change is to implement your suggestion in #2331 where you said: > I am not sure its appropriate for this particular case but one thing to consider in general from an API perspective is letting users pass in ExecutorServices and Thread Factories. There is also a change in this PR to AccumuloUncaughtExceptionHandler where the VM will not be shut down on Error when the thread is not running in an Accumulo Server process (as determined by SingletonManager.getMode). Regarding the BulkImport code above, I believe that in this case an Error would be handled by the AccumuloUncaughtExceptionHandler as [this](https://github.com/apache/accumulo/blob/785a3645261571f000a7adb3c7c72b07886f0587/core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/BulkImport.java#L560) catches Exception, not Error, and the executor that is being used to run the CompletableFuture is being created by ThreadPools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
